Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joltphysics] Export missing compiler definitions #26594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[joltphysics] Export missing compiler definitions #26594

wants to merge 2 commits into from
+17 −0

Conversation

uilianries
Copy link
Member

Changes to recipe: joltphysics/5.2.0

Motivation

I'm able to reproduce the bug reported by #26561. The Joltphysics has several compiler definition exposed as public, but some of them are missing in the recipe: https://github.com/jrouwe/JoltPhysics/blob/v5.2.0/Jolt/Jolt.cmake

fixes #26561

Details

Build logs on Windows, using the example listed in issue #26561

/cc @AbrilRBS

@uilianries uilianries mentioned this pull request Feb 14, 2025
Open
@uilianries uilianries changed the title [joltphysics] Export missing compiler defitions [joltphysics] Export missing compiler definitions Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] joltphysics/5.2.0: minimal working example doesn't work out of the box
2 participants
@uilianries @AbrilRBS